-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force to refresh sync cycle(poll/nudge) when transiting from CONFIGURATION to NORMAL mode. #6363
Conversation
0e25fc3
to
c08d2bb
Compare
c08d2bb
to
3262bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
follow-up issue created brave/brave-browser#11118 |
…ATION to NORMAL mode. This is to mitigate the chance of bookmarks duplication when first time sync which is caused by first device send it local bookmarks only after a poll interval(60s). When second device wants to do BookmarkModelMerger::Merge(), it can't get anything from server because first device hasn't sent any. So it commit its own bookmarks which will cause duplication. Note: Chrome has FCM invalidation ready so its first device will receive notification within ~10s
3262bb9
to
b0561e7
Compare
unrelated CI failure
https://ci.brave.com/job/pr-brave-browser-sync-v2-initial-merge/4/execution/node/648/log/ |
LGTM to uplift
I am still able to reproduce if I create the sync chain within few(2) seconds, but it is still a big improvement. |
This is to mitigate the chance of bookmarks duplication when first time
sync which is caused by first device send it local bookmarks only after
a poll interval(60s). When second device wants to do
BookmarkModelMerger::Merge(), it can't get anything from server because
first device hasn't sent any. So it commit its own bookmarks which will
cause duplication.
Note: Chrome has FCM invalidation ready so its first device will receive
notification within ~10s
Resolves brave/brave-browser#11116
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
STR in brave/brave-browser#11116
Reviewer Checklist:
After-merge Checklist:
changes has landed on.