-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Brave Rewards service is associated to Tor Profiles #6418
Conversation
ad2aadc
to
cd46486
Compare
CI failed for Windows, rebuilding Windows |
CI failed for Windows, restarting Windows |
@yrliou Could you please review the changes for this temporary fix, thanks |
66878e0
to
95abda5
Compare
Verification PASSED on
Once the above was done, created a new
Ensured that no other files that might look ads/rewards related are appearing in
Went through the STR/Cases outlined via brave/brave-browser#11042 (comment) and ensured that I didn't received random ads from other regions nor two ads at the same time. I went through the case ~20 times and couldn't reproduce. |
@kjozwiak |
Resolves brave/brave-browser#11223
Resolves brave/brave-browser#11042
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
ads_service
,rewards_service
and any other related rewards files are not located in~/Library/Application Support/BraveSoftware/Brave-Browser/Default/session_profiles/Tor Profile
Reviewer Checklist:
After-merge Checklist:
changes has landed on.