Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Rewards service is associated to Tor Profiles #6418

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 13, 2020

Resolves brave/brave-browser#11223
Resolves brave/brave-browser#11042

Submitter Checklist:

Test Plan:

  • Confirm ads_service, rewards_service and any other related rewards files are not located in ~/Library/Application Support/BraveSoftware/Brave-Browser/Default/session_profiles/Tor Profile

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey requested a review from darkdh August 13, 2020 12:10
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 13, 2020

CI failed for Windows, rebuilding Windows

@tmancey
Copy link
Collaborator Author

tmancey commented Aug 13, 2020

CI failed for Windows, restarting Windows

@tmancey tmancey closed this Aug 14, 2020
@tmancey tmancey deleted the issues/11223 branch August 14, 2020 10:14
@tmancey tmancey restored the issues/11223 branch September 7, 2020 11:55
@tmancey tmancey reopened this Sep 7, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Sep 7, 2020

@yrliou Could you please review the changes for this temporary fix, thanks

@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.16.4 Chromium: 85.0.4183.102 (Official Build) nightly (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Test Case 1 - running through STR/Cases outlined via #6418 (comment)

  • launched Nightly via the following:
--args --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6 --rewards=staging=true --brave-ads-staging
  • enabled rewards
  • claimed UGP grant
  • viewed ad (ensured ad notification appeared and was counted via brave://rewards)
  • opened brave://rewards-internals/ and clicked on Logs --> Download full log (nothing should happen)
  • logged into a KYC'd staging account via Uphold
  • tipped both https://kjozwiakstaging.github.io & https://laurenwags.github.io

Once the above was done, created a new Tor Window and ensured that the following folders/files weren't being created/appeared within session_profiles/Tor Profile:

* ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/ads_service
* ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/rewards_service
* ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/Rewards.log
* ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/publisher_info_db

Ensured that no other files that might look ads/rewards related are appearing in session_profiles/Tor Profile/ads_service. The following still appears but seems to be empty/doesn't have any information logged which will be addressed in a separate issue.

~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/heavy_ad_intervention_opt_out.db

Test Case 2 - running through STR/Cases outlined via brave/brave-browser#11042 (comment)

Went through the STR/Cases outlined via brave/brave-browser#11042 (comment) and ensured that I didn't received random ads from other regions nor two ads at the same time. I went through the case ~20 times and couldn't reproduce.

@tmancey
Copy link
Collaborator Author

tmancey commented Sep 9, 2020

@kjozwiak ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/heavy_ad_intervention_opt_out.db is not related to brave rewards, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants