Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit promotion link to US (uplift to 1.13.x) #6433

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Limit promotion link to US (uplift to 1.13.x) #6433

merged 1 commit into from
Aug 18, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 17, 2020 •
edited by kjozwiak
Loading

Uplift of #6427
Resolves brave/brave-browser#11239

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 17, 2020 19:12
@brave-builds brave-builds self-assigned this Aug 17, 2020
@brave-builds brave-builds added this to the 1.13.x - Beta milestone Aug 17, 2020
@NejcZdovc NejcZdovc removed their request for review August 17, 2020 19:15
@kjozwiak
Copy link
Member

@NejcZdovc you'll need to rebase your PR as every platform is failing due to the following:

hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: NODE_LABEL for class: WorkflowScript

@NejcZdovc NejcZdovc force-pushed the pr6427_uphold-link_1.13.x branch from 2bf6a95 to cea3677 Compare August 18, 2020 03:52
kjozwiak
kjozwiak approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6427 (comment).

@kjozwiak kjozwiak merged commit eedb1ce into 1.13.x Aug 18, 2020
@kjozwiak kjozwiak deleted the pr6427_uphold-link_1.13.x branch August 18, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @NejcZdovc @brave-browser-releases