Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all favicon requests on-demand (fixes brave/internal#716) #6435

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Aug 18, 2020

Resolves brave/brave-browser#11506.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from bridiver as a code owner August 18, 2020 01:59
@fmarier fmarier self-assigned this Aug 18, 2020
@fmarier fmarier marked this pull request as draft August 18, 2020 01:59
@fmarier fmarier force-pushed the on-demand-favicons branch 5 times, most recently from 190c36e to e4fd381 Compare August 29, 2020 00:56
@fmarier fmarier marked this pull request as ready for review August 29, 2020 00:56
@fmarier fmarier added this to the 1.15.x - Nightly milestone Aug 29, 2020
This patch can be dropped once https://crbug.com/1096660 is fixed
as long as the test is retained and still passes.
@fmarier
Copy link
Member Author

fmarier commented Sep 1, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Favicon caching
2 participants