Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cookie defaults to GetCookieSetting #651

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Move cookie defaults to GetCookieSetting #651

merged 1 commit into from
Oct 18, 2018

Conversation

pilgrim-brave
Copy link
Contributor

Fixes brave/brave-browser#1449

Fixes brave/brave-browser#1592

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, I also tested it on mac, works fine.

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is code in brave_cookie_settings.cc already have test coverage?

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override the approve just to make sure it already has test coverage before merging.

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered in brave_content_settings_observer_browsertest.cc, thanks for confirming, Mark!

@bbondy bbondy merged commit a52c537 into master Oct 18, 2018
bbondy added a commit that referenced this pull request Oct 18, 2018
Move cookie defaults to GetCookieSetting
bbondy added a commit that referenced this pull request Oct 18, 2018
Move cookie defaults to GetCookieSetting
@bbondy
Copy link
Member

bbondy commented Oct 18, 2018

master: a52c537
0.57.x: 27b75a6
0.56.x: 2e22eff
0.55.x: dc6c2bd

bbondy added a commit that referenced this pull request Oct 18, 2018
Move cookie defaults to GetCookieSetting
@bsclifton bsclifton deleted the mpilgrim_cookies branch October 18, 2018 22:50
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants