Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve subresources for IPFS and IPNS too #6582

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Resolve subresources for IPFS and IPNS too #6582

merged 1 commit into from
Sep 8, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 4, 2020

Resolves brave/brave-browser#11572

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy requested a review from yrliou September 4, 2020 19:56
@bbondy bbondy requested a review from iefremov as a code owner September 4, 2020 19:56
@bbondy bbondy self-assigned this Sep 4, 2020
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 39b61ba into master Sep 8, 2020
@bbondy bbondy deleted the ipfs-content branch September 8, 2020 20:36
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow non top level navs for IPFS
2 participants