Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chromium 70.0.3538.67 #659

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Upgrade to Chromium 70.0.3538.67 #659

merged 2 commits into from
Oct 17, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 17, 2018 •
edited
Loading

Fix brave/brave-browser#1629

Easier to review per commit

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Oct 17, 2018
@bbondy bbondy requested a review from bsclifton October 17, 2018 04:08
bsclifton
bsclifton previously approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit 3c2d249 into master Oct 17, 2018
@bbondy bbondy changed the title 70.0.3538.67 Upgrade to Chromium 70.0.3538.67 Oct 17, 2018
bbondy added a commit that referenced this pull request Oct 17, 2018
@bbondy
Merge pull request #659 from brave/70.0.3538.67
99d2da8 
70.0.3538.67
bbondy added a commit that referenced this pull request Oct 17, 2018
@bbondy
Merge pull request #659 from brave/70.0.3538.67
a9b0de0 
70.0.3538.67
bbondy added a commit that referenced this pull request Oct 17, 2018
@bbondy
Merge pull request #659 from brave/70.0.3538.67
70c219c 
70.0.3538.67
@bbondy
Copy link
Member Author

bbondy commented Oct 17, 2018

master: 3c2d249
0.57.x: 99d2da8
0.56.x: a9b0de0
0.55.x: 70c219c

@bsclifton bsclifton deleted the 70.0.3538.67 branch November 5, 2018 18:49
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #659 from brave/multi_channel_install_on_mac
4277528 
Enable different channel apps run simultaneously on MacOS
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #659 from brave/multi_channel_install_on_mac
58c59f5 
Enable different channel apps run simultaneously on MacOS
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #659 from brave/multi_channel_install_on_mac
a4f8a64 
Enable different channel apps run simultaneously on MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 70.0.3538.54 to 70.0.3538.67
2 participants
@bbondy @bsclifton