latest edits #660
Merged
latest edits #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Oct 17, 2018
| @@ -217,7 +217,7 @@ | |||
| <message name="IDS_BRAVE_WELCOME_PAGE_NEXT_BUTTON" desc="Button to move to the next slide of the welcome tour">Next</message> | |||
| <message name="IDS_BRAVE_WELCOME_PAGE_DONE_BUTTON" desc="Button that ends the welcome tour and moves the user to the new tab page">Done</message> | |||
|
|
|||
| <!-- WebUI rewards resources --> | |||
| <!-- WebUI rewards resources --> | |||
There was a problem hiding this comment.
Can you revert this line
NejcZdovc
reviewed
Oct 17, 2018
| @@ -425,6 +423,7 @@ | |||
| <message name="IDS_BRAVE_UI_WELCOME_HEADER_ONE" desc="">We’ve given Brave Payments a big upgrade.</message> | |||
| <message name="IDS_BRAVE_UI_WELCOME_HEADER_TWO" desc="">Get ready to experience the next Internet.</message> | |||
| <message name="IDS_BRAVE_UI_WHY_BRAVE_REWARDS" desc="">Why Brave Rewards?</message> | |||
| <message name="IDS_BRAVE_UI_WHY_BRAVE_REWARDS_DESC" desc=""> </message> | |||
There was a problem hiding this comment.
This needs to be removed
NejcZdovc
force-pushed
the
bradleyrichter-patch-1
branch
from
b20418f to
5b9c32f
Compare
NejcZdovc
force-pushed
the
bradleyrichter-patch-1
branch
from
5b9c32f to
21a3bd2
Compare
NejcZdovc
approved these changes
Oct 17, 2018
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
New apply_patches command is more memorable than sync --run_hooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for brave/brave-browser#1578
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: