Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10607: Show warnings for TLS 1.0 and TLS 1.1 (uplift to 1.14.x) #6617

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 10, 2020

Uplift of #6574
Resolves brave/brave-browser#10607

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team September 10, 2020 17:28
@brave-builds brave-builds self-assigned this Sep 10, 2020
@brave-builds brave-builds added this to the 1.14.x - Release milestone Sep 10, 2020
@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to GreaselionServiceTest.ScriptInjectionWithPrecondition failing as per https://ci.brave.com/job/pr-brave-browser-pr6574_legacy_tls_warnings_1.14.x-windows/1/execution/node/216/log/. However, the failure is a known intermittent error that doesn't block uplift.

16:16:48  [  FAILED  ] GreaselionServiceTest.ScriptInjectionWithPrecondition, where TypeParam =  and GetParam() =  (2913 ms)
16:16:48  
16:16:48  [605/605] GreaselionServiceTest.ScriptInjectionWithPrecondition (3113 ms)
16:16:48  1 test failed:
16:16:48      GreaselionServiceTest.ScriptInjectionWithPrecondition (../../brave/browser/greaselion/greaselion_browsertest.cc:265)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6574 (comment).

@kjozwiak kjozwiak merged commit c7a7064 into 1.14.x Sep 11, 2020
@kjozwiak kjozwiak deleted the pr6574_legacy_tls_warnings_1.14.x branch September 11, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants