-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 85 to Chromium 86 (1.15.x). #6677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade from Chromium 85 to Chromium 86.
Do not create cookie page action icon/view.
Create zip in deb building script
Settings UI: hides passwords item in Safety Check section.
Upgrade patches from Chromium 86.0.4240.30 to Chromium 86.0.4240.42.
Original change was made with Chromium 86 upgrade in commit c989436. This is a followup specific to 1.15.x.
mkarolin
requested review from
bbondy,
bridiver,
darkdh,
iefremov,
kylehickinson,
NejcZdovc,
ryanml,
simonhong and
tmancey
as code owners
September 21, 2020 21:53
28 tasks
This was referenced Sep 22, 2020
kjozwiak
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.15.x
approved after deliberating with @brave/uplift-approvers. QA has also verified/ran through C86 on Nightly via the following manual passes:
- Manual test run on Win x64 for 1.16.x - Nightly (Checking CR86) Fix temporary object return. (uplift to 1.34.x) #11729 - Manual test run on Win x64 for 1.16.x - Nightly (Checking CR86) brave-browser#11729
- Manual test run on Android for 1.16.x - Nightly (Checking CR86) Move cookie list override logic to account for uninitialized preferences #11730 - Manual test run on Android for 1.16.x - Nightly (Checking CR86) brave-browser#11730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#10884
Fixes brave/brave-browser#11709
Fixes brave/brave-browser#11504
Fixes brave/brave-browser#11741
Fixes brave/brave-browser#11747
Related PR: brave/brave-browser#11800
Uplifts from #6195, #6657, #6662, #6600, #6642
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.