Adds error handling for Bitcoin.com widget #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
reviewed
Oct 9, 2020
| return ( | ||
| <Styled.FooterWrapper> | ||
| <Styled.BuyButton onClick={this.openBuyURL}> | ||
| <Styled.BuyButton |
There was a problem hiding this comment.
nit: disabled if there is an error?
petemill
reviewed
Oct 9, 2020
| @@ -226,7 +249,7 @@ export const BuyButton = styled<{}, 'button'>('button')` | |||
| padding: 12px 0px; | |||
| font-weight: bold; | |||
| font-size: 13px; | |||
| cursor: pointer; | |||
| cursor: ${p => p.error ? 'default' : 'pointer'}; | |||
petemill
reviewed
Oct 9, 2020
| @@ -18,6 +18,7 @@ interface State { | |||
| currentAmount: string | |||
| assetsShowing: boolean | |||
| fiatCurrenciesShowing: boolean | |||
| amountError: boolean | |||
There was a problem hiding this comment.
nit: if this were a string then you could support multiple types of error (null would mean no error), but I guess here there is only 1 invalid amount error case?
There was a problem hiding this comment.
Correct yeah, this is the only path to user error at the moment
AlanBreck
reviewed
Oct 9, 2020
components/brave_new_tab_ui/components/default/bitcoinDotCom/style.ts
Outdated
Show resolved
Hide resolved
AlanBreck
reviewed
Oct 9, 2020
components/brave_new_tab_ui/components/default/bitcoinDotCom/style.ts
Outdated
Show resolved
Hide resolved
AlanBreck
reviewed
Oct 9, 2020
| @@ -227,6 +250,10 @@ export const BuyButton = styled<{}, 'button'>('button')` | |||
| font-weight: bold; | |||
| font-size: 13px; | |||
| cursor: pointer; | |||
|
|
|||
| &:disabled { | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
Possibly drop the opacity when disabled?
AlanBreck
reviewed
Oct 9, 2020
AlanBreck
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#11960
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.