Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DDG newtab in Qwant region if Qwant is not used #685

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 18, 2018

In Qwant region, DDG newtab should be used when user uses non-Qwant
search engine provider.
In non-Qwant region, user always see DDG newtab.

Close brave/brave-browser#1666

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Set region to France.
  2. Start Browser with clean profile
  3. Open private window and check non-ddg newtab is used
  4. Change search engine setting
  5. Then reopen private window and checks ddg newtab is used

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

In Qwant region, DDG newtab should be used when user uses non-Qwant
search engine provider.
In non-Qwant region, user always see DDG newtab.
@simonhong simonhong self-assigned this Oct 18, 2018
@bsclifton
Copy link
Member

Getting clarification from @davidtemkin about how this should work. Since it's been changed a few times, would be great to have a solid set of requirements 😄 Hang tight!

@davidtemkin
Copy link

DDG should never be promoted / shown / defaulted on in Qwant regions. In Qwant regions, we default to Qwant for search in all types of windows, including private and private/tor and do not promote DDG.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the behavior we would like with @davidtemkin and updated issue to have a proper test plan 😄 (which I manually verified). This should be good to go! 😄

@bsclifton bsclifton merged commit 0be354a into master Oct 18, 2018
@bsclifton bsclifton deleted the show_ddg_in_qwant_region branch October 18, 2018 16:45
bsclifton added a commit that referenced this pull request Oct 18, 2018
Show DDG newtab in Qwant region if Qwant is not used
bsclifton added a commit that referenced this pull request Oct 18, 2018
Show DDG newtab in Qwant region if Qwant is not used
@bsclifton
Copy link
Member

master 0be354a
0.57.x 63157e0
0.56.x 64101fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle Qwant in private windows + tor windows
4 participants