Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panel text for rewards #690

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Fixes panel text for rewards #690

merged 1 commit into from
Oct 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 18, 2018

Resolves brave/brave-browser#1635

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • make sure that you see panel text
  • reload site
  • make sure that you see tables
  • clean profile
  • enable rewards
  • visit a site
  • open new tab
  • make sure that you see tables

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 18, 2018
@NejcZdovc NejcZdovc requested a review from bbondy October 18, 2018 12:46
@NejcZdovc NejcZdovc merged commit 45cf7c5 into master Oct 18, 2018
@NejcZdovc NejcZdovc deleted the panel_text branch October 18, 2018 13:24
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Fixes panel text for rewards
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Fixes panel text for rewards
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Fixes panel text for rewards
@NejcZdovc
Copy link
Contributor Author

master 45cf7c5
0.57.x ed8864c
0.56.x f9c0469
0.55.x e97d3d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

first load of brave://rewards does not show panel text
2 participants