Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix farbling in disconnected iframes #6941

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 23, 2020

Resolves brave/brave-browser#12303

Submitter Checklist:

Test Plan:

See: brave/brave-browser#12303 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner October 23, 2020 19:59
@pilgrim-brave pilgrim-brave self-assigned this Oct 23, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_disconnected_iframes branch from f50f858 to ca0f465 Compare October 23, 2020 19:59
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the frames logic, but from overrides/patches point LGTM

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_disconnected_iframes branch from ca0f465 to 28d321d Compare October 28, 2020 21:02
@pilgrim-brave
Copy link
Contributor Author

CI failures are unrelated.

@pilgrim-brave pilgrim-brave merged commit c528812 into master Oct 28, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_disconnected_iframes branch October 28, 2020 23:06
@pilgrim-brave pilgrim-brave added this to the 1.18.x - Beta milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas farbling doesn't happen in disconnected iframes
2 participants