Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove navigator.deviceMemory (part 1)" #6965

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 27, 2020

Fixes brave/brave-browser#12289

This reverts commit 740b4e3 which was added in #3669 to fix brave/brave-browser#1157.

Submitter Checklist:

Test Plan:

Testing is not 100% reliable, but the idea is to compare a current version of Brave with this build:

  1. Using Nightly (without this PR), clear all cookies, history, etc.
  2. Open the devtool console and type navigator.deviceMemory (should return undefined).
  3. Log into Paypal and suffer through the CAPTCHA.
  4. Using this build, clear all cookies, history, etc.
  5. Open the devtool console and type navigator.deviceMemory (should return a number).
  6. Log into Paypal and you shouldn't get a CAPTCHA.
  7. Open https://antoinevastel.com/bots/ and confirm that everything is green at the bottom:
    Screenshot from 2020-10-27 12-15-34
  8. Open https://arh.antoinevastel.com/bots/areyouheadless and confirm that it says "You are not Chrome headless".

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 1.18.x - Nightly milestone Oct 27, 2020
@fmarier fmarier requested a review from a team as a code owner October 27, 2020 18:55
@fmarier fmarier self-assigned this Oct 27, 2020
@mkarolin
Copy link
Collaborator

mkarolin commented Oct 27, 2020

#6962
#6964
Seem to be covering the same issue.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Oct 29, 2020

Verification PASSED on macOS 10.15.7 x64 using the following build:

  • verified that navigator.deviceMemory returns a number via the DevTools rather than undefined
  • visited https://antoinevastel.com/bots/ and verified that everything appeared green

Screen Shot 2020-10-29 at 3 19 58 PM

Note: this doesn't fix the reCAPTCHA issue so you'll still most likely see CAPTCHA's until that's resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert "navigator.deviceMemory" Fingerprinting attribute: navigator.deviceMemory
4 participants