Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x) #6970

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x) #6970

merged 1 commit into from
Oct 28, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 27, 2020 •
edited by kjozwiak
Loading

Fixes: brave/brave-browser#12347
Partial Uplift of: #6963

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@jumde jumde requested a review from a team October 27, 2020 23:29
@jumde jumde self-assigned this Oct 27, 2020
@jumde jumde changed the title Fix 12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 Oct 27, 2020
@jumde jumde changed the title Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x) Oct 27, 2020
@jumde jumde added this to the 1.16.x - Release #2 milestone Oct 27, 2020
kjozwiak
kjozwiak approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.16.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit bf874e7 into 1.16.x Oct 28, 2020
@kjozwiak kjozwiak deleted the fix_rust_deps_1.16.x branch October 28, 2020 05:50
This was referenced Oct 28, 2020
Merged
Merged
Merged
bsclifton pushed a commit that referenced this pull request Oct 29, 2020
@kjozwiak @bsclifton
Merge pull request #6970 from brave/fix_rust_deps_1.16.x
23761f7 
Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x)
@bsclifton
Copy link
Member

pulled into 1.15.x with 23761f7

Brandon-T pushed a commit that referenced this pull request Oct 30, 2020
@kjozwiak @Brandon-T
Merge pull request #6970 from brave/fix_rust_deps_1.16.x
aa53073 
Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x)
Brandon-T pushed a commit that referenced this pull request Nov 3, 2020
@kjozwiak @Brandon-T
Merge pull request #6970 from brave/fix_rust_deps_1.16.x
e0afdcb 
Fix #12347: Updating RUST_DEPS_PACKAGE_VERSION to 0.1.5 (Uplift to 1.16.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
1.16.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@jumde @bsclifton @kjozwiak