Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates countries for uphold promotion #6982

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 29, 2020

Resolves brave/brave-browser#12372

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip Do not run CI builds (except noplatform) labels Oct 29, 2020
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 29, 2020
@NejcZdovc NejcZdovc requested a review from a team October 29, 2020 16:16
@NejcZdovc NejcZdovc self-assigned this Oct 29, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team October 29, 2020 16:16
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 1442808 into master Oct 29, 2020
@NejcZdovc NejcZdovc deleted the uphol-promo-countries branch October 29, 2020 16:54
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.18.19 Chromium: 87.0.4280.27 (Official Build) nightly (x86_64)
-- | --
Revision | d8c1fe98de8d9c6bd46ebe8b0cc9d2b6bdccca1e-refs/branch-heads/4280@{#556}
OS | macOS Version 10.15.7 (Build 19H2)
Countries without promo Countries with promo
Screen Shot 2020-10-29 at 10 44 53 PM Screen Shot 2020-10-29 at 11 01 35 PM

@kjozwiak
Copy link
Member

@NejcZdovc @mandar-brave should https://uphold.com/en/buy-fractional-shares/brave be redirected to https://uphold.com/en/buy-fractional-shares? Right now it basically opens the above link using /brave and than redirects. Expected?

@kjozwiak kjozwiak mentioned this pull request Oct 30, 2020
33 tasks
@NejcZdovc
Copy link
Contributor Author

expected, this is fully controlled by uphold

@kjozwiak
Copy link
Member

@NejcZdovc do we need to remove the U.S part from the card now that US was removed from the list of supported regions?

Screen Shot 2020-10-30 at 10 14 45 AM

CCing @LaurenWags

@NejcZdovc
Copy link
Contributor Author

@kjozwiak nope all good, this is more meant as that you can trade with US companies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update country list for Equity Cards
3 participants