Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add //third_party/blink/public/common to browser_process deps #7066

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

mrobinson
Copy link
Contributor

@mrobinson mrobinson commented Nov 5, 2020

brave_tab_helpers.cc uses an include from this directory, so a
dependency is necessary.

Resolves brave/brave-browser#12515.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

brave_tab_helpers.cc uses an include from this directory, so a
dependency is necessary.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member

Linux failed because of intermittent browser test: (see brave/brave-browser#12555)

04:06:19  1 test failed:
04:06:19      RewardsContributionBrowserTest.MultipleTipsProduceMultipleFeesWithVerifiedWallet (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:475)

Windows failed because of intermittent browser test: (see brave/brave-browser#12295)

1 test failed:
08:31:40      RewardsContributionBrowserTest.RecurringTipForUnverifiedPublisher (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:327)

Otherwise looks good! Merging

@bsclifton bsclifton merged commit f9d15be into master Nov 6, 2020
@bsclifton bsclifton deleted the fix-tab-helpers-dependencies branch November 6, 2020 18:37
@bsclifton bsclifton added this to the 1.18.x - Nightly milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave_tab_helpers.cc is missing a dependency on third_party/blink/public/common
3 participants