Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes single column regression, scrollbar overlap #7089

Closed
wants to merge 1 commit into from

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 8, 2020

Fixes brave/brave-browser#12573, brave/brave-browser#12381

Screen Shot 2020-11-07 at 7 05 23 PM

Screen Shot 2020-11-07 at 7 05 18 PM

Screen Shot 2020-11-07 at 7 05 12 PM

Resolves

Submitter Checklist:

Test Plan:

Defined in issues

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@@ -361,6 +362,7 @@ export const StyledWidgetToggle = styled<WidgetToggleProps, 'button'>('button')`
border: none;
margin-top: 8px;
cursor: pointer;
height: 41px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natural height when in the "Hide" state was already 41px, but when toggling to "Add", was bumped down to 40.6px, better to just keep this constant.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong
Copy link
Member

@ryanml Can you check this again with latest master?
I think this issue seems not reproducible anymore with master now.

@ryanml
Copy link
Contributor Author

ryanml commented Nov 9, 2020

@simonhong looks like neither of these issues are a problem as of #6192, thanks!

@ryanml ryanml closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards layout bug of More Cards in NTP Customize Dashboard
3 participants