-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel fixes #712
Panel fixes #712
Conversation
8b7544f
to
ca9845b
Compare
Getting a warning when creating wallet from OptIn screen: |
Fixes panel favicon Resolves brave/brave-browser#1719 Resolves brave/brave-browser#1792
ca9845b
to
e88e385
Compare
@jasonrsadler this is not related to this PR, but @ryanml fixed it in brave-ui, so is part of new version that will be updated in sep PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and works well!
Changed merged label to 0.56.x since this won't appear in 0.55.x hotfix2. |
Fixes panel favicon
Fixes panel create wallet
Fixes on restart panel show
Fixes panel not clearing after a switch
Resolves brave/brave-browser#1719
Resolves brave/brave-browser#1792
Resolves brave/brave-browser#1777
Resolves brave/brave-browser#1660
Ledger implementation brave-intl/bat-native-ledger#154
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: