Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase rewards browsertest timeout values #7185

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Nov 18, 2020

Resolves brave/brave-browser#12295
Resolves brave/brave-browser#12396

This PR increases the amount of time that rewards browser tests will wait for a particular element to be rendered within a document, from the current 5 seconds to 10 seconds. Doubling the time should not have an adverse impact on CI since many of the tests which current exceed this timeout will timeout at the gtest level as well.

I ran CI on macOS and Windows twice with this change and did not see a rewards browsertest timeout.

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

CI should fail less often on rewards browser tests.

@zenparsing zenparsing added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Nov 18, 2020
@zenparsing zenparsing requested a review from a team as a code owner November 18, 2020 16:18
@zenparsing zenparsing force-pushed the ksmith-rewards-browsertest-fixes branch from d674a56 to 87b4413 Compare November 18, 2020 20:30
@zenparsing zenparsing force-pushed the ksmith-rewards-browsertest-fixes branch from 87b4413 to bfbc27e Compare November 18, 2020 22:23
@zenparsing zenparsing removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 19, 2020
@zenparsing zenparsing changed the title Tweak rewards browsertest timeout values Increase rewards browsertest timeout values Nov 19, 2020
@zenparsing zenparsing self-assigned this Nov 19, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit cd99eec into master Nov 19, 2020
@zenparsing zenparsing deleted the ksmith-rewards-browsertest-fixes branch November 19, 2020 21:49
@zenparsing zenparsing added this to the 1.19.x - Nightly milestone Nov 20, 2020
brave-builds pushed a commit that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants