Only load IPFS subresources within IPFS/IPNS schemes #7194
Conversation
bbondy
force-pushed
the
ipfs-same-scheme
branch
2 times, most recently
from
d706b02
to
afe446d
Compare
bbondy
force-pushed
the
ipfs-same-scheme
branch
from
afe446d
to
d923edf
Compare
| namespace network_utils { | ||
|
|
||
| bool IsURLHandledByNetworkService(const GURL& url) { | ||
| if (url.SchemeIs("ipns") || url.SchemeIs("ipfs")) { |
There was a problem hiding this comment.
minor, but I'd try to transform all of "ipfs"/"ipns" to some constant defined somewhere at ipfs_constants.h
There was a problem hiding this comment.
I think I'd have to patch in a dependency in that case no?
| ASSERT_TRUE(ExecuteScriptAndExtractBool( | ||
|
|
||
| std::string location; | ||
| ASSERT_TRUE(ExecuteScriptAndExtractString( |
There was a problem hiding this comment.
ExecuteScriptAndExtractString is deprecated in favor of EvalJs (see browser_test_utils.h). Also it should be possible to set an onload handler (i.e. avoid using the timer)
| "}, 100);", | ||
| &location)); | ||
|
|
||
| ASSERT_EQ(location, "chrome-error://chromewebdata/"); |
There was a problem hiding this comment.
I think EXPECT_EQ is more widespreaded across the codebase
There was a problem hiding this comment.
I think they are different, expect eq keeps running the test but assert eq fails the test instantly
There was a problem hiding this comment.
They are indeed different, and the default choice is typically EXPECT_EQ. Not something important, especially for the last assertion in a test, just style
bbondy
force-pushed
the
ipfs-same-scheme
branch
2 times, most recently
from
13a83ad
to
8d5e0ae
Compare
For some reason they are blocked when not done from the network service. I checked with Ivan and BrianJ and they are OK with marking ipns and ipfs as handled by the network service
bbondy
force-pushed
the
ipfs-same-scheme
branch
from
9717ee5
to
762bd0a
Compare
When a local node is installed, by visiting a page that allows you to load IPFS resources, it will then make you a host of any resources that the page loads. To avoid this, this PR makes ipfs:// and ipns subresources only load when the top level main frame is also ipfs:// or ipns://.
This PR also fixes a problem where iframes would not load at all that were ipfs scheme.
It also removes the external protocol handler that existed.
Resolves brave/brave-browser#12546
Resolves brave/brave-browser#12931
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan: