Promo code is never claimed if user closes browser too soon #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1811
We previously only looked for the promoCode file on first
run. However, since there's a short delay before we launch the task to
read the promoCode file, there's a window of opportunity for a user to
close the browser before we read the file. This puts the user in a
state where the first run has occurred but the promoCode file wasn't
read (and therefore won't ever be read).
We now use a Boolean preference to achieve the same effect, but since
it's not tied to first-run it will allow us to continue to look for
the promoCode file even in the above scenario. Once we've checked for
the promoCode file we flip the flag so that there's no long-term
cost.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: