Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added ability to prevent auto downloading and opening #7279

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Nov 30, 2020

Resolves brave/brave-browser#12902

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 30, 2020
@samartnik samartnik added this to the 1.19.x - Nightly milestone Nov 30, 2020
@samartnik samartnik self-assigned this Nov 30, 2020
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_open_downloads branch from f4f54e9 to a52e525 Compare November 30, 2020 19:41
@samartnik samartnik changed the title [Android] Added ability to revent auto downloading and opening [Android] Added ability to prevent auto downloading and opening Nov 30, 2020
@samartnik samartnik merged commit b7da1a5 into master Nov 30, 2020
@samartnik samartnik deleted the android_open_downloads branch November 30, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent auto downloading & opening a PDF file on click
3 participants