Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with ads per day incorrectly limited to ads per hour #7454

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 16, 2020

Resolves brave/brave-browser#13215

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#13215

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmancey tmancey force-pushed the issues/13215 branch 2 times, most recently from 8544eef to c8820a5 Compare December 16, 2020 15:14
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration path LGTM!

@mihaiplesa mihaiplesa merged commit c9cd292 into master Dec 16, 2020
@mihaiplesa mihaiplesa deleted the issues/13215 branch December 16, 2020 17:58
@tmancey tmancey added this to the 1.20.x - Nightly milestone Dec 16, 2020
@kjozwiak
Copy link
Member

Reproduced the original issue on macOS 11.0.1 using the following build:

Brave | 1.20.33 Chromium: 88.0.4315.5 (Official Build) nightly (x86_64)
--- | ---
Revision | d2abe4588adaeb0d66aa0a0106675be1dff12c64-refs/branch-heads/4315@{#11}
OS | macOS Version 11.0.1 (Build 20B29)

Set Maximum number of ads displayed to 2 and went through the following:

  • installed 1.20.33 CR: 88.0.4315.5 and viewed an ad (received without issues)
  • waited ~30mins and viewed another ad without any issues
  • waited ~30mins and never received an ad due to hitting the daily limit

Verification PASSED on macOS 11.0.1 using the following build:

Brave | 1.20.36 Chromium: 88.0.4315.5 (Official Build) nightly (x86_64)
--- | ---
Revision | d2abe4588adaeb0d66aa0a0106675be1dff12c64-refs/branch-heads/4315@{#11}
OS | macOS Version 11.0.1 (Build 20B29)

Went through the same STR mentioned above and ensured that the third ad appears in the second hour.

Example Example
Screen Shot 2020-12-17 at 2 40 17 AM Screen Shot 2020-12-17 at 2 40 01 AM

@brave brave deleted a comment from trankimtrong Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads per hour frequency cap incorrectly limits based on adsPerHour not adsPerDay
4 participants