Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebRTC support URL #748

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Update WebRTC support URL #748

merged 1 commit into from
Oct 26, 2018
+1 −1

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 26, 2018 •
edited
Loading

Fix brave/brave-browser#1690

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Visit chrome://settings/privacy, WebRTC learn more link should now points to https://support.brave.com/hc/en-us/articles/360017989132-How-do-I-change-my-Privacy-Settings-#webrtc.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 26, 2018
@yrliou yrliou force-pushed the update_webrtc_support_url branch from cd3344e to 6918897 Compare October 26, 2018 18:48
@yrliou yrliou requested a review from cezaraugusto October 26, 2018 18:50
cezaraugusto
cezaraugusto approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@yrliou yrliou merged commit 63f05a8 into master Oct 26, 2018
yrliou added a commit that referenced this pull request Oct 26, 2018
@yrliou
Merge pull request #748 from brave/update_webrtc_support_url
b56ffc9 
Update WebRTC support URL
yrliou added a commit that referenced this pull request Oct 26, 2018
@yrliou
Merge pull request #748 from brave/update_webrtc_support_url
bc46f23 
Update WebRTC support URL
@yrliou yrliou deleted the update_webrtc_support_url branch October 26, 2018 18:54
@yrliou
Copy link
Member Author

yrliou commented Oct 26, 2018

master: 63f05a8
0.56.x: b56ffc9
0.57.x: bc46f23

@LaurenWags LaurenWags mentioned this pull request Oct 31, 2018
Closed
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

change WebRTC learn more link from article on github to article on support site
3 participants
@yrliou @cezaraugusto @bbondy