Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the ConnMgr.HighWater and LowWater limits #7577

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 13, 2021

Resolves brave/brave-browser#13525

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Fresh profile...
  • Open the profile directory
  • Open brave_ipfs/config
    The values should be updated for the section Swarm.ConnMgr for LowWater and HighWater

Screen Shot 2021-01-13 at 11 26 35 AM

The default is ConnMgr.LowWater=600 and HighWater=900

It should now be changed to:

LowWater=50 and HighWater=300

@bbondy bbondy force-pushed the ipfs-high-low-water branch from b338575 to 9a35a5f Compare January 13, 2021 00:25
@bbondy bbondy marked this pull request as ready for review January 13, 2021 00:47
@bbondy bbondy force-pushed the ipfs-high-low-water branch from 9a35a5f to c6d8321 Compare January 13, 2021 15:58
@bbondy bbondy force-pushed the ipfs-high-low-water branch from c6d8321 to d8d4cb0 Compare January 13, 2021 16:26
@bbondy bbondy requested a review from yrliou January 13, 2021 16:29
@bbondy bbondy self-assigned this Jan 13, 2021
@bbondy
Copy link
Member Author

bbondy commented Jan 13, 2021

macOS had a build failure but it works locally so it's not related.

@bbondy bbondy merged commit 9a59e5f into master Jan 13, 2021
@bbondy bbondy deleted the ipfs-high-low-water branch January 13, 2021 18:35
brave-builds pushed a commit that referenced this pull request Jan 13, 2021
@kjozwiak kjozwiak added this to the 1.20.x - Beta milestone Jan 14, 2021
@LaurenWags
Copy link
Member

Verified using

Brave | 1.21.1 Chromium: 88.0.4324.79 (Official Build) nightly (x86_64)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 10.15.7 (Build 19H15)

Verified test plan from #7577 (comment)

Using a clean profile, visited ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR to trigger IPFS infobar.
Installed IPFS from infobar.
Opened ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/brave_ipfs/config file.

Screen Shot 2021-01-14 at 8 17 44 AM

Confirmed updated config values of LowWater=50 and HighWater=300.

Screen Shot 2021-01-14 at 8 18 37 AM

Spot checked able to load ipfs:// and ipns:// URLs without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS config: lower the ConnMgr.HighWater and LowWater limits
4 participants