Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom Brave ad notifications should not be shown on Dev channel builds #7608

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 15, 2021

Resolves brave/brave-browser#13592

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm custom ad notifications are only shown on Nightly (Canary) build channels

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmancey tmancey merged commit af91e44 into master Jan 15, 2021
@tmancey tmancey deleted the issues/13592 branch January 15, 2021 11:27
@tmancey tmancey added this to the 1.21.x - Nightly milestone Jan 15, 2021
@LaurenWags
Copy link
Member

Verified using

Brave | 1.21.13 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Confirmed custom ad notification shown on Nightly:
Screen Shot 2021-01-19 at 4 45 54 PM

Other channels to be checked once uplifted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Brave ad notifications should not be shown on Dev channel builds
3 participants