Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button color in IPFS interstitial page in light theme (uplift to 1.20.x) #7620

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Fix button color in IPFS interstitial page in light theme (uplift to 1.20.x) #7620

merged 1 commit into from
Jan 17, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 15, 2021 •
edited by kjozwiak
Loading

Uplift of #7619
Resolves brave/brave-browser#13599

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team January 15, 2021 20:00
@brave-builds brave-builds self-assigned this Jan 15, 2021
@brave-builds brave-builds added this to the 1.20.x - Beta milestone Jan 15, 2021
@yrliou
Copy link
Member

yrliou commented Jan 16, 2021

Tested using the test plan in #7619 using downloaded Linux PR build from the original PR.

@yrliou
Copy link
Member

yrliou commented Jan 16, 2021 •
edited
Loading

macOS kept failing or timed out with unrelated reasons, still trying but for this particular change I think it's pretty safe since it's just a trivial css change and it's already passed on all other platforms and also all green in the 1.19.x PR.
All CI builds are green now.

kjozwiak
kjozwiak approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7619 (comment).

@kjozwiak kjozwiak merged commit d56dd4a into 1.20.x Jan 17, 2021
@kjozwiak kjozwiak deleted the pr7619_ipfs_fix_button_color_in_light_1.20.x branch January 17, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @yrliou @kjozwiak @brave-browser-releases