Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nightly launcher on Linux #7685

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Fix Nightly launcher on Linux #7685

merged 1 commit into from
Jan 28, 2021

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 23, 2021

Resolves brave/brave-browser#1746

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In addition to the test plan in brave/brave-browser#1746, the following quick check can confirm that it's working:

  1. Run xprop WM_CLASS in a terminal.
  2. Click on the Brave Nighly window.
  3. Confirm that it says: `WM_CLASS(STRING) = "brave-browser-nightly", "Brave-browser-nightly"

@fmarier fmarier added this to the 1.21.x - Nightly milestone Jan 23, 2021
@fmarier fmarier requested a review from a team as a code owner January 23, 2021 03:13
@fmarier fmarier self-assigned this Jan 23, 2021
@fmarier fmarier marked this pull request as draft January 23, 2021 03:13
@fmarier fmarier marked this pull request as ready for review January 26, 2021 04:32
@fmarier fmarier requested a review from mkarolin January 26, 2021 04:33
@bsclifton bsclifton changed the title Fix Nighthly launcher on Linux Fix Nightly launcher on Linux Jan 26, 2021
@fmarier fmarier force-pushed the fix-nightly-wmclass-1746 branch 2 times, most recently from e46dbb5 to a060815 Compare January 26, 2021 19:11
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fmarier
Copy link
Member Author

fmarier commented Jan 28, 2021

Based on a Slack discussion for this known issue, I am ignoring the Windows signing failure.

@fmarier fmarier merged commit cb5b450 into master Jan 28, 2021
@fmarier fmarier deleted the fix-nightly-wmclass-1746 branch January 28, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly shortcut links to wrong version on Linux
2 participants