-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch first run dialog on macOS and linux #7700
Conversation
d658210
to
b577920
Compare
b577920
to
7626c35
Compare
7626c35
to
9a4c9b5
Compare
48feb39
to
156afef
Compare
2283e59
to
2cdf368
Compare
chromium_src/chrome/browser/first_run/first_run_internal_posix.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/first_run/first_run_internal_posix.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/cocoa/first_run_dialog_controller.mm
Outdated
Show resolved
Hide resolved
Implementation looks good, just want to double-check presence of P3A in this dialog, see Slack https://bravesoftware.slack.com/archives/CDNJ9SVUL/p1611956161037900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
10a74c5
to
4625915
Compare
Kindly ping to @brave/patch-reviewers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ on chromium_src
4625915
to
dfdb2d5
Compare
|
Resolves brave/brave-browser#12679
Development build doesn't launch this dialog.(https://github.com/brave/brave-core/pull/7700/files#diff-edfdf2e925a57fc30614d6d3ee529e49a5d9d29afe5eef326f1a83f09b456818R32)
On macOS:
On linux:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: