Fix infinite OpenInTorWindow looping when auto redirect through navigation throttle. #7713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change window disposition to SWITCH_TO_TAB to avoid redundant new
tab.
We no longer close the original tab to avoid confusion and lots of users complained about this behavior.
The crash cause is calling
chrome::FindTabbedBrowser
withmatch_original_profiles
equals true soOnionLocationNavigationThrottle::WillStartRequest
got triggered endlessly.Resolves brave/brave-browser#13736
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
Crash
brave/brave-browser#13736 (comment)
Window disposition and original tab
brave.com
ttps://brave5t5rjjg3s6k.onion
and no new tab in Tor windowhttps://www.torproject.org/
http://expyuzz4wqqyqhjn.onion/index.html
will be opened in Tor windowhttps://brave5t5rjjg3s6k.onion
andhttp://expyuzz4wqqyqhjn.onion/index.html