-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading of PDF protected by cookie-based login #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjozwiak
added
uplift-approved/0.56.x-Beta
and removed
uplift-request/0.56.x-Beta
labels
Nov 1, 2018
yrliou
force-pushed
the
fix_cookie_based_auth_pdf
branch
from
November 1, 2018 18:59
b8096ce
to
fb86c2c
Compare
bbondy
approved these changes
Nov 1, 2018
Thanks! |
I'm not entirely sure if it's the same issue, but I'm seeing the following error when trying to view a PDF file in my Bank's website:
with the following 3 errors in the console:
|
Yep that should be fixed, mainly any site that you had to login to first and then you click to see a PDF would fail. Next week's release will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brave/brave-browser#1287 was fixed in 0.57.x and later by #744.
This PR fixes it for 0.56.x without refactoring how we do cookie blocking.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See brave/brave-browser#1788 (comment)
Reviewer Checklist: