Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant BRAVE_INIT patch in chrome/test/base/testing_profile.cc #7930

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Feb 11, 2021

The original code block is no longer run on desktop platforms.

Resolves brave/brave-browser#14103

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The original code block is no longer run on desktop platforms.
@yrliou yrliou added this to the 1.22.x - Nightly milestone Feb 11, 2021
@yrliou yrliou requested a review from bridiver February 11, 2021 06:48
@yrliou yrliou requested a review from a team as a code owner February 11, 2021 06:48
@yrliou yrliou self-assigned this Feb 11, 2021
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yrliou yrliou merged commit 28bda22 into master Feb 11, 2021
@yrliou yrliou deleted the remove_patching_testing_profile branch February 11, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove BRAVE_INIT patch in chrome/test/base/testing_profile.cc
2 participants