Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start and stop button should only show when it is applicable #7937

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 11, 2021

Resolves brave/brave-browser#14115

Start and stop button should only show when it is applicable

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave://ipfs page
  • Start and stop button should only show when it is applicable

@spylogsster spylogsster requested a review from bbondy February 11, 2021 19:20
@spylogsster spylogsster self-assigned this Feb 11, 2021
@spylogsster spylogsster merged commit 41da07b into master Feb 12, 2021
@spylogsster spylogsster deleted the ipfs-page-button branch February 12, 2021 05:40
@spylogsster spylogsster added this to the 1.22.x - Nightly milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve start and stop button behaviour for brave://ipfs
2 participants