-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a permission lifetime combobox into permission UI bubble. #7982
Conversation
@pes10k feel free to share your thoughts, maybe there is a better naming scheme for the feature/components/etc. |
<part file="crypto_dot_com_strings.grdp" /> | ||
<part file="ipfs_strings.grdp" /> | ||
<part file="permissions_strings.grdp" /> | ||
<part file="speedreader_strings.grdp" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it in alphabetical order. Shouldn't break anything, but if someone thinks the other way, please say it.
chromium_src/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view.cc
Show resolved
Hide resolved
@goodov i think the change looks good, but that it might be best to wait for @karenkliu before committing any UI changes, in case she (or others on the design team) think something other than a drop down is best |
chromium_src/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view.cc
Show resolved
Hide resolved
@bridiver PTAL ? |
d25f9d1
to
37a955c
Compare
@mkarolin could you please take a look at the changes as a patch-reviewer? |
chromium_src/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view.cc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending deps verification, chromium_src
changes LGTM
Add base parts for the upcoming feature (
strings
,base::Feature
) and additional element into permission UI bubble to allow the user choose a lifetime for permissions. This change contains only a UI implementation.Fixes brave/brave-browser#14127
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: