Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a permission lifetime combobox into permission UI bubble. #7982

Merged
merged 11 commits into from
Mar 5, 2021

Conversation

goodov
Copy link
Member

@goodov goodov commented Feb 17, 2021

Add base parts for the upcoming feature (strings, base::Feature) and additional element into permission UI bubble to allow the user choose a lifetime for permissions. This change contains only a UI implementation.

Fixes brave/brave-browser#14127

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from bridiver and a team as code owners February 17, 2021 14:33
@goodov goodov self-assigned this Feb 17, 2021
@goodov goodov requested a review from pes10k February 17, 2021 14:40
@goodov
Copy link
Member Author

goodov commented Feb 17, 2021

@pes10k feel free to share your thoughts, maybe there is a better naming scheme for the feature/components/etc.
Here is how the UI part looks now: brave/brave-browser#14127 (comment)

<part file="crypto_dot_com_strings.grdp" />
<part file="ipfs_strings.grdp" />
<part file="permissions_strings.grdp" />
<part file="speedreader_strings.grdp" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it in alphabetical order. Shouldn't break anything, but if someone thinks the other way, please say it.

components/resources/permissions_strings.grdp Outdated Show resolved Hide resolved
@pes10k
Copy link
Contributor

pes10k commented Feb 18, 2021

@goodov i think the change looks good, but that it might be best to wait for @karenkliu before committing any UI changes, in case she (or others on the design team) think something other than a drop down is best

browser/BUILD.gn Outdated Show resolved Hide resolved
@iefremov
Copy link
Contributor

@bridiver PTAL ?

@goodov goodov force-pushed the issues/14127 branch 2 times, most recently from d25f9d1 to 37a955c Compare February 25, 2021 14:24
@goodov
Copy link
Member Author

goodov commented Mar 1, 2021

@mkarolin could you please take a look at the changes as a patch-reviewer?

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending deps verification, chromium_src changes LGTM

@goodov goodov added this to the 1.23.x - Nightly milestone Mar 5, 2021
@goodov goodov merged commit 2a11ec9 into master Mar 5, 2021
@goodov goodov deleted the issues/14127 branch March 5, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change permission UI on Desktop to enable / expose "permission until X" ability
6 participants