Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Handle new Rewards boolean option to prevent runtime crash #8050

Closed
wants to merge 1 commit into from

Conversation

kylehickinson
Copy link
Collaborator

Resolves

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added feature/rewards CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 23, 2021
@kylehickinson kylehickinson added this to the 1.22.x - Nightly milestone Feb 23, 2021
@kylehickinson kylehickinson self-assigned this Feb 23, 2021
@kylehickinson kylehickinson requested a review from a team February 23, 2021 20:46
@kylehickinson
Copy link
Collaborator Author

Closing as it will be handled in #8054

@kylehickinson kylehickinson deleted the ios-boolean-pref-crash-fix branch February 24, 2021 16:47
@kylehickinson kylehickinson removed this from the 1.23.x - Nightly milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants