Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BAP reporting endpoint (uplift to 1.22.x) #8075

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Add support for BAP reporting endpoint (uplift to 1.22.x) #8075

merged 1 commit into from
Mar 8, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 25, 2021 •
edited by kjozwiak
Loading

Uplift of #8054
Resolves brave/brave-browser#14315

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing added this to the 1.22.x - Beta milestone Feb 25, 2021
@zenparsing zenparsing requested review from emerick and removed request for a team February 25, 2021 13:36
@zenparsing zenparsing requested a review from a team February 25, 2021 13:37
@kjozwiak
Copy link
Member

kjozwiak commented Feb 26, 2021 •
edited
Loading

Holding the uplift and waiting till we get more information next week re: if we need this uplifted.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2021

audit_deps failed in post-init due to a known failure as per https://ci.brave.com/job/pr-brave-browser-ksmith-bap-reporting-1.22-post-init/1/execution/node/145/log/. However, this doesn't block uplift as it's not related to this specific PR.

kjozwiak
kjozwiak approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8054 (comment).

@bsclifton closed #8074 in favour of #8178. So once #8178 has been completed, this work will also land in 1.21.x.

@kjozwiak kjozwiak merged commit 95d10db into 1.22.x Mar 8, 2021
@kjozwiak kjozwiak deleted the ksmith-bap-reporting-1.22 branch March 8, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson kylehickinson is a code owner

@emerick emerick Awaiting requested review from emerick

Assignees

@zenparsing zenparsing

Labels
None yet
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @kjozwiak