Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pylint and pylint-report targets. #8222

Merged
merged 9 commits into from
Mar 15, 2021
Merged

Added pylint and pylint-report targets. #8222

merged 9 commits into from
Mar 15, 2021

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Mar 11, 2021

This PR adds two npm scripts/targets - pylint (for manual use) and pylint-report (for use in CI). This is mainly, so it can be used here https://github.com/brave/devops/pull/4631, so there's no issue in this repo corresponding to this PR.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 11, 2021
@wknapik wknapik requested a review from mihaiplesa as a code owner March 11, 2021 17:25
@wknapik wknapik changed the title Added the pylint-report stage to pre-init. Added pylint and pylint-report targets. Mar 11, 2021
@mihaiplesa mihaiplesa requested a review from bridiver March 12, 2021 01:03
@wknapik
Copy link
Collaborator Author

wknapik commented Mar 15, 2021

@mihaiplesa this is ready for merging and after this is merged, this https://github.com/brave/devops/pull/4631 should be merged to complete the work.

@mihaiplesa mihaiplesa added this to the 1.23.x - Nightly milestone Mar 15, 2021
@mihaiplesa mihaiplesa merged commit 04b4d0f into master Mar 15, 2021
@mihaiplesa mihaiplesa deleted the wknapik-pylint branch March 15, 2021 18:55
@mihaiplesa mihaiplesa mentioned this pull request Mar 18, 2021
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants