Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cname url when blocking (uplift to 1.21.x) #8267

Closed
wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #8262
Resolves brave/brave-browser#14756

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from iefremov as a code owner March 16, 2021 15:52
@brave-builds brave-builds requested a review from a team March 16, 2021 15:52
@brave-builds brave-builds self-assigned this Mar 16, 2021
@brave-builds brave-builds added this to the 1.21.x - Release #5 milestone Mar 16, 2021
@kjozwiak
Copy link
Member

Closing the 1.21.x uplift after speaking with @antonok-edm. 1.22.x is slated to release on March 23 and I doubt we'll get another CR bump for 1.21.x. Either way, this can go out Tuesday.

@kjozwiak kjozwiak closed this Mar 17, 2021
@kjozwiak kjozwiak removed request for iefremov and a team March 17, 2021 20:18
@kjozwiak kjozwiak removed this from the 1.21.x - Release #5 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants