Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close site settings pages #8367

Closed
wants to merge 15 commits into from
Closed

Close site settings pages #8367

wants to merge 15 commits into from

Conversation

alexsafe
Copy link
Contributor

Resolves
brave/brave-browser#12181

Submitter Checklist:

  • [x ] I confirm that no security/privacy review is needed, or that I have requested one
  • [ x] There is a ticket for my issue
  • [ x] Used Github auto-closing keywords in the PR description above
  • [x ] Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [ x] Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 26, 2021
@alexsafe alexsafe added this to the 1.24.x - Nightly milestone Mar 26, 2021
@alexsafe alexsafe requested review from samartnik and a team as code owners March 26, 2021 14:45
@alexsafe alexsafe self-assigned this Mar 26, 2021
samartnik
samartnik requested changes Mar 26, 2021
View reviewed changes
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "brave-core",
"version": "1.24.26",
"version": "1.24.27",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this changed for this task

patches/chrome-VERSION.patch Outdated
@@ -9,4 +9,4 @@ index e2b916f5f9efbab982e7bd1eb84c347ec6ba66b3..cd358992759c45df459ac208abd3d7a4
-PATCH=30
+MINOR=1
+BUILD=24
+PATCH=26
+PATCH=27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this changed for this task

@alexsafe alexsafe force-pushed the close_site_settings_pages branch from 52c3d17 to e528149 Compare March 26, 2021 17:12
@alexsafe alexsafe closed this Mar 26, 2021
@alexsafe alexsafe deleted the close_site_settings_pages branch June 10, 2021 20:28
kylehickinson added a commit that referenced this pull request Jan 4, 2024
@kylehickinson
Fix #8364: Add missing footer constraint when bottom toolbar is hidden (
11bb042 
#8367)

Missing this constraint would cause the web view container view to have ambiguous height and result in a 0-height web page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik requested changes

@deeppandya deeppandya Awaiting requested review from deeppandya

@SergeyZhukovsky SergeyZhukovsky Awaiting requested review from SergeyZhukovsky

Assignees

@alexsafe alexsafe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsafe @samartnik @brave-browser-releases