Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New style for ipfs buttons #8464

Merged
merged 1 commit into from
Apr 7, 2021
Merged

New style for ipfs buttons #8464

merged 1 commit into from
Apr 7, 2021

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#14452
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave://ipfs and check buttons

@spylogsster spylogsster merged commit ea4fb0c into master Apr 7, 2021
@spylogsster spylogsster deleted the ipfs-new-buttons branch April 7, 2021 16:00
@spylogsster spylogsster added this to the 1.25.x - Nightly milestone Apr 7, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
…ettings (#8464)

Update chain list when custom networks list is opened to handle case when opened via browser settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS: My Node button should be a different color from Start/Stop/Restart buttons
2 participants