-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IPNS keys settings option #8660
Conversation
310b607
to
dd9236e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things that still need addressing:
-
API Permissions fixing
-
When testing it I noticed that when I reload brave://settings/ipfs and I click on:
Setup your IPNS keys
it does a refresh on the page and doesn't work until I click it a second time. -
When I was testing it I clicked to add a key but got this in the console
Unchecked runtime.lastError: IPFS node is not launched
. No error message was displayed though in the page. I didn't have a node installed yet on my local node. We should only show this section when local node is selected in preferences and a node is installed. -
After it is installed but I restart the browser so the node isn't running, I get
Unchecked runtime.lastError: Unable to create key
. In this case I think it should start the already installed node.
f24afaa
to
c9e1d6a
Compare
a7fedba
to
ed8de2c
Compare
done |
5149504
to
db5fce1
Compare
Writing down things from today's sync (could be extracted into separate PRs / issues)
|
b1ff9fd
to
f669d27
Compare
2d1ec33
to
d40cda5
Compare
d40cda5
to
2c992fd
Compare
Second part of brave/brave-browser#15422
First part here #8609
Normal mode
Node is not launched
Unable to start node
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
- If current method is local node you should be asked to start the node and see launch error. There's a linked text that can be clicked to navigate to new brave://ipfs tab
- If current method is not local node you must be redirected to brave://ipfs