Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.24.x release (1.24.x). #8670

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#15514
Uplift from #8663

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team April 29, 2021 14:22
@mkarolin mkarolin self-assigned this Apr 29, 2021
@mkarolin
Copy link
Collaborator Author

mkarolin commented Apr 29, 2021

CI failure:

  • MacOS - browser tests crashes are unrelated to this PR:
5 tests crashed:
     BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion068WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
     BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
     BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
     BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForUnsupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
     BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion12WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)

@kjozwiak kjozwiak added this to the 1.24.x - Release milestone Apr 29, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x after deliberating with @brave/uplift-approvers. QA will verify the PR and all associated l10n issues within the 1.24.x RC.

@kjozwiak kjozwiak merged commit 2bf1019 into 1.24.x Apr 29, 2021
@kjozwiak kjozwiak deleted the maxk-release-1.24.x-l10n-1.24.x branch April 29, 2021 18:55
kylehickinson pushed a commit that referenced this pull request Jan 22, 2024
Changing Model to Latest 27 Model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants