-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux compilation errors #88
Conversation
These changes fix the build in my Ubuntu 16.04 VM. I ran into a confusing compilation error caused by sccache while working on this, but am going to file a separate issue for that since use of sccache is optional. @AlexeyBarabash Could you confirm that this PR fixes your Linux builds? |
With this PR, I can build and run brave on linux(ubuntu 16.04). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Changes looks good. Build on Linux had succeeded. Thanks @garrettr . |
Fixes Linux compilation errors that were introduced in #77.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
yarn run sync --run_hooks
to apply the updated patches.Reviewer Checklist: