Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux compilation errors #88

Merged
merged 3 commits into from
Apr 10, 2018

Conversation

garrettr
Copy link
Contributor

@garrettr garrettr commented Apr 6, 2018

Fixes Linux compilation errors that were introduced in #77.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

  1. Checkout this branch and run yarn run sync --run_hooks to apply the updated patches.
  2. Build on Linux. The build should complete without errors.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@garrettr garrettr requested a review from AlexeyBarabash April 6, 2018 18:33
@garrettr garrettr changed the title Fix errors in os_crypt patch files for Linux Fix Linux compilation errors Apr 9, 2018
@garrettr
Copy link
Contributor Author

garrettr commented Apr 9, 2018

These changes fix the build in my Ubuntu 16.04 VM. I ran into a confusing compilation error caused by sccache while working on this, but am going to file a separate issue for that since use of sccache is optional.

@AlexeyBarabash Could you confirm that this PR fixes your Linux builds?

@simonhong
Copy link
Member

With this PR, I can build and run brave on linux(ubuntu 16.04).

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Apr 10, 2018

Changes looks good. Build on Linux had succeeded. Thanks @garrettr .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants