Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keep alive flag value (uplift to 1.25.x) #8809

Merged
merged 1 commit into from
May 18, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 14, 2021

Uplift of #8787
Resolves brave/brave-browser#15815

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 14, 2021 16:45
@brave-builds brave-builds requested a review from a team May 14, 2021 16:45
@brave-builds brave-builds self-assigned this May 14, 2021
@brave-builds brave-builds added this to the 1.25.x - Beta milestone May 14, 2021
@kjozwiak
Copy link
Member

post-init failed audit-deps due to several warning(s) as per https://ci.brave.com/job/pr-brave-browser-pr8787_keep-alive-flag_1.25.x-post-init/1/execution/node/144/log/. However, the warning(s) are known and unrelated to this specific PR.

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-pr8787_keep-alive-flag_1.25.x-linux/1/testReport/. However, these are known intermittent failures and unrelated to this specific PR.

BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForUnsupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / RewardsContributionBrowserTest.AutoContributionMultiplePublishersUphold
linux / test-browser / RewardsPublisherBrowserTest.VisitRegisteredPublisher

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8787 (comment).

@kjozwiak kjozwiak merged commit 7feca8f into 1.25.x May 18, 2021
@kjozwiak kjozwiak deleted the pr8787_keep-alive-flag_1.25.x branch May 18, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants