Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show ipfs items if the ipfs daemon is not launched #8856

Merged
merged 1 commit into from
May 20, 2021

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#15935

  • Do not show IPFS app menu if ipfs daemon is not launched

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check that IPFS item is not visible in main app menu if ipfs daemon is not launched
  • Pinning with ipfs keys works as expected

@spylogsster spylogsster requested a review from bbondy May 18, 2021 22:35
@spylogsster spylogsster self-assigned this May 18, 2021
@spylogsster spylogsster changed the title Do not show menu if the ipfs daemon is not launched Do not show ipfs items if the ipfs daemon is not launched May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share local file/dir using IPFS does not work on desktop
2 participants