Customize user dir on linux #89
Conversation
Brave support four different user dir depends on channel. * Brave-Browser for stable release * Brave-Browser-Beta for beta release * Brave-Browser-Dev for dev release * Brave-Development for unofficial build Canary channel isn't supported on linux. Channel suffixes are determined from $CHROME_VERSION_EXTRA, which is passed by the launch wrapper script. For more detail, see src/docs/user_data_dir.md#Linux
Functions in this header is only used in official build.
| std::string modifier; | ||
| std::string data_dir_suffix; | ||
|
|
||
| char* env = getenv("CHROME_VERSION_EXTRA"); |
There was a problem hiding this comment.
do we have brave-browser PR that set this env?
It would be better if you link other depended PR in a PR. Just put depends [url] in commit or PR description.
There was a problem hiding this comment.
I assume that we reuse chromium's packaging target in //chrome/installer/linux.
With that, this env is set by wrapper( https://cs.chromium.org/chromium/src/chrome/installer/linux/common/wrapper)
There was a problem hiding this comment.
I wonder how we can trigger these targets
https://cs.chromium.org/chromium/src/chrome/installer/linux/BUILD.gn?l=517-525
so that we can have proper CHANNEL in wrapper?
There was a problem hiding this comment.
Sorry for late reply.
Afaik, we can do it by yarn create_dist.
With that, //chrome/installer/linux target is built.
That target should create each channe's installer with proper channel setting.
There was a problem hiding this comment.
I mean how to control the channel setting, or is it build all available channels at once?
There was a problem hiding this comment.
Hmm, create_dist command doesn't have channel option.
Current create_dist would make all three channels at once.
There was a problem hiding this comment.
Should create_dist support channel option?
There was a problem hiding this comment.
I can accept current behavior and you can do channel option as follow-up
There was a problem hiding this comment.
Always thanks for valuable review! @darkdh
Corrected publisher state not getting loaded
Use new size graphic for browser action icon graphic
pass real cc_wrapper in env var
pass real cc_wrapper in env var
pass real cc_wrapper in env var
Issue: brave/brave-browser#10
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Set $CHROME_VERSION_EXTRA to "" or "beta" or "unstable" and check user dir in ~/.config/
Reviewer Checklist: