Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn user when they want to reset sync chain #917

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Nov 15, 2018

fix https://gthub.com/brave/brave-browser/issues/2134
Fix brave/brave-browser#2134

test plan

  • try to reset sync
  • should show a warning
  • confirm resets sync
  • cancel do nothing

@cezaraugusto cezaraugusto merged commit 4f83500 into master Nov 16, 2018
@cezaraugusto cezaraugusto deleted the cez-sync-warn-reset branch November 16, 2018 01:51
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
warn user when they want to reset sync chain
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
warn user when they want to reset sync chain
@cezaraugusto
Copy link
Contributor Author

master 4f83500
0.58.x 46b8a7c
0.57.x 905fdf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset sync should show warning message to user, if sync is already established between two devices
3 participants