Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base::SequenceBound to hold an instance of LedgerDatabase #9203

Closed
wants to merge 1 commit into from

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#15779

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing force-pushed the ksmith-database-sequence-bound branch from 9d3da8e to a4a11cb Compare June 21, 2021 17:01
@emerick emerick self-requested a review June 21, 2021 19:48
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in previous PR, would like to make sure everything works at runtime for iOS before this is merged

Code changes lgtm though

@zenparsing zenparsing force-pushed the ksmith-database-sequence-bound branch 2 times, most recently from 5b6bd8b to 3f595a8 Compare June 21, 2021 22:12
@zenparsing zenparsing requested review from bridiver and iefremov June 24, 2021 18:55
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewards service part looks fine, except I don't understand whether it's okay to remove those extra reset()s. Everything else also look good to me in general

@zenparsing zenparsing force-pushed the ksmith-database-sequence-bound branch from 3f595a8 to de82723 Compare July 7, 2021 16:58
@zenparsing zenparsing requested a review from a team as a code owner July 7, 2021 16:58
@zenparsing zenparsing force-pushed the ksmith-database-sequence-bound branch from de82723 to a5546b1 Compare July 7, 2021 17:38
@zenparsing zenparsing force-pushed the ksmith-database-sequence-bound branch from a5546b1 to d0b245c Compare July 8, 2021 15:57
@iefremov
Copy link
Contributor

Hey @zenparsing maybe we could give it another try?

@zenparsing
Copy link
Collaborator Author

@iefremov I'll rebase and rerun CI today.

@iefremov
Copy link
Contributor

@zenparsing maybe we could finalize this one? We continue to receive crashdumps

@zenparsing zenparsing closed this May 12, 2022
@zenparsing zenparsing deleted the ksmith-database-sequence-bound branch May 12, 2022 21:50
@iefremov
Copy link
Contributor

hey @zenparsing why this was closed? The fix is still needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in brave_rewards::RunDBTransactionOnFileTaskRunner
4 participants